[
https://issues.apache.org/jira/browse/THRIFT-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987449#comment-14987449
]
ASF GitHub Bot commented on THRIFT-3408:
----------------------------------------
GitHub user aughr opened a pull request:
https://github.com/apache/thrift/pull/679
THRIFT-3408: correct emitted JSON types
https://issues.apache.org/jira/browse/THRIFT-3408
Currently this has no tests associated with it because the JSON generator
itself appears untested. No wonder there was this regression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aughr/thrift THRIFT-3408
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #679
----
commit 69cbfef16dc7e55d9086778779e4b591d019b2b2
Author: Andrew Bloomgarden <[email protected]>
Date: 2015-11-03T15:19:14Z
THRIFT-3408: correct emitted JSON types
----
> JSON generator emits incorrect types
> ------------------------------------
>
> Key: THRIFT-3408
> URL: https://issues.apache.org/jira/browse/THRIFT-3408
> Project: Thrift
> Issue Type: Bug
> Components: JSON - Compiler
> Affects Versions: 0.9.3
> Reporter: Andrew Bloomgarden
> Priority: Minor
>
> This change makes all base types emit "binary" as their type in the JSON
> generator:
> https://github.com/apache/thrift/commit/8dbe5f60a7c1401302e10aec41069f9c385d34a1#diff-e6c383fcc2ee5e64083db96846727639
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
