Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/672#issuecomment-153511243
Thanks for the PR!
We need a strong YES to according to the contribution guidelines as
mentioned here https://thrift.apache.org/docs/HowToContribute (generated from
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md)
I guess CONTRIBUTING.md is displayed when creating a merge request? But
there is no ack... or is pressing the create Merge Request an ACK on the
contribution license?
We probably need to simplify this somehow especially for such small but
essential contributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
