[
https://issues.apache.org/jira/browse/THRIFT-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002232#comment-15002232
]
Konrad Grochowski commented on THRIFT-3415:
-------------------------------------------
I'll do some scans with clang's iwyu (include-what-you-use) and clean a little
bit around in THeader* related includes
> include unistd.h conditionally
> ------------------------------
>
> Key: THRIFT-3415
> URL: https://issues.apache.org/jira/browse/THRIFT-3415
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.4
> Reporter: Pascal Bach
> Assignee: Konrad Grochowski
> Attachments: unistd_include.patch
>
>
> THeaderTransport.h includes unistd.h unconidionaly.
> This breaks on non posix systems.
> The solution is to include it only when the corresponding define is set, like
> it is done in the rest of the codebase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
