[ 
https://issues.apache.org/jira/browse/THRIFT-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011613#comment-15011613
 ] 

ASF GitHub Bot commented on THRIFT-3430:
----------------------------------------

GitHub user justonia opened a pull request:

    https://github.com/apache/thrift/pull/703

    In go THttpClient, explicitly read response body to completion when closing

    Fixes: https://issues.apache.org/jira/browse/THRIFT-3430

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justonia/thrift THRIFT-3430

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/703.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #703
    
----

----


> Go THttpClient does not read HTTP response body to completion when closing
> --------------------------------------------------------------------------
>
>                 Key: THRIFT-3430
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3430
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>            Reporter: Justin Larrabee
>            Priority: Minor
>
> In THttpClient.closeResponse the body of the HTTP response is closed but the 
> body itself is never explicitly read to completion. The go docs specify that 
> if the response body is not read to completion and keepalive is enabled, the 
> connection will never be returned to the pool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to