GitHub user markerickson-wf opened a pull request:

    https://github.com/apache/thrift/pull/706

    THRIFT-3434 Produce a reasonable name for includes in Dart generator

    Use the namespace, if available, then the file name. Previously the Dart 
generator was producing an empty string when a namespace was not provided.
    
    https://issues.apache.org/jira/browse/THRIFT-3434

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markerickson-wf/thrift 
thrift-3434_fix_include_names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #706
    
----
commit 61300245862f4fc9f8b3bd8cf54f2efb8d1a8a07
Author: Mark Erickson <[email protected]>
Date:   2015-11-19T23:58:28Z

    Produce a reasonable name for includes, using the namespace, if available, 
then the file name.  Previously it was producing an empty string when a 
namespace was not provided.
    
    https://issues.apache.org/jira/browse/THRIFT-3434

commit d28e2e994bed1eef1f9c4c8069ab93149320fc63
Author: Mark Erickson <[email protected]>
Date:   2015-11-20T03:27:05Z

    Also replace dash character
    
    https://issues.apache.org/jira/browse/THRIFT-3434

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to