[
https://issues.apache.org/jira/browse/THRIFT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030316#comment-15030316
]
Hudson commented on THRIFT-162:
-------------------------------
SUCCESS: Integrated in Thrift #1743 (See
[https://builds.apache.org/job/Thrift/1743/])
THRIFT-162 Thrift structures are unhashable, preventing them from being (roger:
rev e841b3dac619a5e5d3523d059d48db1a12e41360)
* compiler/cpp/src/generate/t_py_generator.cc
* test/py/RunClientServer.py
* lib/py/src/protocol/TBase.py
* test/py/TestFrozen.py
* lib/py/src/protocol/fastbinary.c
* test/ThriftTest.thrift
* test/DebugProtoTest.thrift
* lib/py/src/protocol/TProtocol.py
* lib/py/src/Thrift.py
> Thrift structures are unhashable, preventing them from being used as set
> elements
> ---------------------------------------------------------------------------------
>
> Key: THRIFT-162
> URL: https://issues.apache.org/jira/browse/THRIFT-162
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler, Python - Library
> Reporter: Esteve Fernandez
> Assignee: Aki Sukegawa
> Priority: Minor
> Fix For: 0.9.3
>
> Attachments: immut-no-slots-v1.diff, immut-v2.diff, immut-v3.diff,
> immut-v4.diff, reading-containers.diff, thrift-162_annotiations.patch,
> thrift-162_v2_annotiations.patch, thrift_py_hash.patch
>
>
> Let Foo be a Thrift structure:
> struct Foo {
> 1: i32 bar
> }
> If you want to use it properly as a set element or a as a dictionary key, the
> autoegenerated Python code will complain about not being hashable:
> >>> f1 = Foo()
> >>> f1.bar = 1
> >>> f2 = Foo()
> >>> f2.bar = 1
> >>> f1 == f2
> True
> >>> set([f1]) & set([f2])
> set([])
> >>> d = {}
> >>> d[f1] = 2
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> TypeError: unhashable instance
> Since Thrift structures already implement __eq__ and __ne__, they should
> implement __hash__ as well. The attached patch tries to mimic the behaviour
> of the Java compiler, including a HashCodeBuilder class written in Python.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
