[
https://issues.apache.org/jira/browse/THRIFT-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reopened THRIFT-3420:
----------------------------------------
Coverity Scan found this issue in the changes:
1 new defect(s) introduced to thrift found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1340250: Control flow issues (DEADCODE)
/lib/cpp/src/thrift/transport/TSSLSocket.cpp: 336 in
apache::thrift::transport::TSSLSocket::read(unsigned char *, unsigned int)()
________________________________________________________________________________________________________
*** CID 1340250: Control flow issues (DEADCODE)
/lib/cpp/src/thrift/transport/TSSLSocket.cpp: 336 in
apache::thrift::transport::TSSLSocket::read(unsigned char *, unsigned int)()
330 switch (error) {
331 case SSL_ERROR_SYSCALL:
332 if ((errno_copy != THRIFT_EINTR)
333 || (errno_copy != THRIFT_EAGAIN)) {
334 break;
335 }
>>> CID 1340250: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "if (retries++ >= this->maxR...".
336 if (retries++ >= maxRecvRetries_) {
337 // THRIFT_EINTR needs to be handled manually and we can
tolerate
338 // a certain number
339 break;
340 }
341 case SSL_ERROR_WANT_READ:
> C++: TSSLSockets are not interruptable
> --------------------------------------
>
> Key: THRIFT-3420
> URL: https://issues.apache.org/jira/browse/THRIFT-3420
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3, 0.9.4, 1.0, 1.1, 1.2
> Reporter: Martin Haimberger
> Fix For: 1.0
>
>
> TSSLSockets are not interruptable.
> Therefore if used as transport in any server implementation, the server
> cannot shutdown if any SSL client is connected.
> Pullrequest on github will follow.
> Pull is https://github.com/apache/thrift/pull/690
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
