[
https://issues.apache.org/jira/browse/THRIFT-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036600#comment-15036600
]
ASF GitHub Bot commented on THRIFT-3471:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/729
THRIFT-3471 Fix inconsistent generation of Uppercase argument names
Pass the argument name through `get_field_name` function, to get a
consistent reference.
https://issues.apache.org/jira/browse/THRIFT-3471
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #729
----
commit 2ddad74abee574c7afcc6427d08d1b0919997967
Author: Mark Erickson <[email protected]>
Date: 2015-12-02T20:41:28Z
Pass the argument name through get_field_name function, to get a consistent
reference.
https://issues.apache.org/jira/browse/THRIFT-3471
----
> Dart generator does not handle uppercase argument names
> -------------------------------------------------------
>
> Key: THRIFT-3471
> URL: https://issues.apache.org/jira/browse/THRIFT-3471
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Compiler
> Reporter: Mark Erickson
> Assignee: Mark Erickson
>
> PROBLEM
> The dart generator produces inconsistent code for argument names that start
> with an uppercase letter. The function signature uses lowercase, but the
> function body uses uppercase.
> SOLUTION
> Pass the argument name through the get_field_name() function, to generate
> code consistent with the other references of argument names.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
