[
https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042589#comment-15042589
]
ASF GitHub Bot commented on THRIFT-3060:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/395#issuecomment-162132438
I don't understand well the original motivation for clearing the queue.
It seems to me, if the user calls some RPC methods it should be either done
or error.
They should not be silently ignored on random automatic reconnects.
If the disconnect is because of erroneous RPC input, the caller is
responsible for properly re-initializing client.
Am I missing something ?
> Node.js client retry logic doesn't flush offline queue on reconnect
> -------------------------------------------------------------------
>
> Key: THRIFT-3060
> URL: https://issues.apache.org/jira/browse/THRIFT-3060
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: Chris Thompson
> Priority: Minor
> Attachments: thrift-3060-fix_retry_logic.patch
>
>
> The Node.js client includes retry logic in case the connection terminates
> unexpectedly. On reconnect, the `offline_queue` variable never gets reset,
> so any requests still in the queue will get processed on every reconnect.
> In addition, the variables the keep track of the retry state are not
> initialized prior to a successful connection, meaning that if the initial
> connection doesn't succeed, that the retry timer is set to `NaN` and doesn't
> work as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
