[ 
https://issues.apache.org/jira/browse/THRIFT-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047479#comment-15047479
 ] 

James E. King, III commented on THRIFT-965:
-------------------------------------------

Is this still an issue in today's implementation?  This issue is pretty old.  I 
added it to the C++ Library component.  If that isn't correct please fix.

> Use a queue instead of a set to record interest changes in NonblockingServer
> ----------------------------------------------------------------------------
>
>                 Key: THRIFT-965
>                 URL: https://issues.apache.org/jira/browse/THRIFT-965
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.2, 0.3, 0.4, 0.5
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>
> Right now we use a HashSet to record interest changes. This requires us to 
> synchronize on access to it which seems like an unnecessary contention 
> bottleneck. Instead, if we used a queue, we could do standard 
> producer/consumer and use more granular locks (if any).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to