[
https://issues.apache.org/jira/browse/THRIFT-3496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066347#comment-15066347
]
ASF GitHub Bot commented on THRIFT-3496:
----------------------------------------
GitHub user szenker opened a pull request:
https://github.com/apache/thrift/pull/752
Thrift 3496: C++: Cob style client fails when sending a consecutive request
see THRIFT-3496
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/szenker/thrift THRIFT-3496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit 430fec6afc9647ccd2dadfef3bc99f1b5ba39485
Author: Sebastian Zenker <[email protected]>
Date: 2015-12-18T15:15:08Z
fixed: sending a second request via Cob style client wasn't working as the
otrans_ buffer still contained the content from the first request
commit 656d7ad24b0984dbc959b7130c97e1d128a400bb
Author: Sebastian Zenker <[email protected]>
Date: 2015-12-18T15:21:12Z
fixed: TEvhttpClientChannel - when sending a second request (via
sendAndRecvMessage()) before the first cob of the first request has signaled
that a response is available, the cob of the first request gets overwritten by
the second request. Consequently, the cob of the first request never gets
called and cob of the second gets called twice.
commit b9a65d539adeecbd09a88138272922c8df490e7b
Author: Sebastian Zenker <[email protected]>
Date: 2015-12-21T11:16:23Z
extended the cpp TestClient to issue consecutive calls on the same client
----
> C++: Cob style client fails when sending a consecutive request
> --------------------------------------------------------------
>
> Key: THRIFT-3496
> URL: https://issues.apache.org/jira/browse/THRIFT-3496
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 1.0
> Environment: Linux
> Reporter: Sebastian Zenker
> Priority: Critical
> Labels: easyfix
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I extended the C++ unit tests to send a second request using the same
> generate client instance (without recreating it). This causes the following
> two problems:
> 1.) the client still has the first request in it's output buffer causing it
> to send the first request again and again
> 2.) the wrong cob gets called, as sending the second request will always
> overwrite the cob of the first request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
