GitHub user simonsouth opened a pull request:
https://github.com/apache/thrift/pull/764
Thrift 3383 i64 related warnings
These changes reduce the number of compiler warnings, and eliminate all
warnings related to 64-bit values, generated when building the C (GLib) test
suite on a 32-bit platform with a C90-compliant compiler (as gcc was by default
until fairly recently).
This fixes THRIFT-3383. This pull request also includes the fixes for
THRIFT-3498 and THRIFT-3512.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/simonsouth/thrift
thrift-3383-i64-related-warnings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit 5fbe84f68871009aaa8adf55579b048c164dd403
Author: Simon South <[email protected]>
Date: 2015-12-21T19:01:36Z
THRIFT-3498 C++ library assumes optional function
pthread_attr_setschedpolicy is available
PosixThreadFactory.cpp: Test for availability of optional
pthread_attr_setschedpolicy function before including in source code
commit 51bf5d83765d7bbea475cf8b6389f3a345d8a572
Author: Simon South <[email protected]>
Date: 2015-12-29T17:02:18Z
THRIFT-3512 c_glib: Build fails due to missing features.h
testbinaryprotocol.c: Include features.h only on platforms with GNU
libc.
commit 4d0efc324ff2919b227f83f4cdc8b99223b18cb9
Author: Simon South <[email protected]>
Date: 2015-12-24T01:29:29Z
c_glib: Compiler: Silence integer-too-large warnings
Wrap output 64-bit integer constants in GLib's G_GINT64_CONSTANT macro
so the generated code will compile without warnings using a
C90-compliant compiler on a 32-bit system.
commit 30e5d461e7f1c8a5d32a8c651011de74f448b619
Author: Simon South <[email protected]>
Date: 2015-12-29T15:43:23Z
c_glib: test: Reduce warnings on 32-bit platforms
Reduce the number of compiler warnings generated when building the C
(GLib) test suite on a 32-bit platform (particularly with a
C90-compliant compiler).
- testbinaryprotocol.c:
- testdebugproto.c: Wrap 64-bit constants in GLib's G_GINT64_CONSTANT
macro.
- testoptionalrequired.c: Replace C++-style comment with C-style
equivalent.
- testserialization.c: Separate variable declarations from code.
- testthrifttestclient.cpp: Use stream operators to output results
(avoiding warnings related to 64-bit values) instead of printf.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
