GitHub user markerickson-wf opened a pull request:

    https://github.com/apache/thrift/pull/770

    THRIFT-3520 Dart TSocket onError type as Object

    Dart TSocket exposes `onError` as a `Stream<String>`. However, the payload 
may be either a String or an Error, and should be typed as `Stream<Object>`.  
    
    This is a follow up to https://issues.apache.org/jira/browse/THRIFT-3468, 
and really should have been done with that change.
    
    https://issues.apache.org/jira/browse/THRIFT-3520
    
    @evanweible-wf
    @tylertreat-wf
    @stevenosborne-wf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markerickson-wf/thrift thrift-3520

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #770
    
----
commit b5504ae3bb8469a0b0e65d2c9b1f99ac25336705
Author: Mark Erickson <[email protected]>
Date:   2016-01-04T21:10:25Z

    Dart TSocket exposes an onError Stream<String>. However, the payload may be 
either a String or an Error, and should be typed as Stream<Object>.
    
    https://issues.apache.org/jira/browse/THRIFT-3520

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to