[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083620#comment-15083620
]
ASF GitHub Bot commented on THRIFT-3521:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169105689
I was mainly concerned about completely losing map/set tests.
Of course preserving all tests for those element types is great, but I
think it's fine to unset most of them, as long as some/one of tests for both
map and set is retained.
> TSimpleJSONProtocolTest is not deterministic (fails when run on JDK 8)
> ----------------------------------------------------------------------
>
> Key: THRIFT-3521
> URL: https://issues.apache.org/jira/browse/THRIFT-3521
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Environment: OpenJDK 8
> Reporter: Benjamin Gould
> Assignee: Benjamin Gould
> Priority: Minor
> Fix For: 0.9.4
>
>
> TSimpleJSONProtocolTest has a couple of tests where structs are serialized,
> and the resultant JSON string is compared for equality with an expected value.
> Some of the structs' fields are sets, which do not ensure consistent
> ordering, causing this test to fail in environments where the "natural"
> ordering of the elements in the HashSet do not match the expected value.
> Suggested fix is to unset the fields that cause the inconsistent ordering and
> remove them from the expected value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
