Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169691258
thrift_reserved_keyword(yytext); is used to report "Cannot use reserved
language keyword: " (reserved in Thrift target languages, not Thrift itself).
As "union" is already used by Thrift, it does not need to be additionally
reserved. "Public" is just repeated (looks like typo).
So for those changes: +1
But last one seems more complicated - at least looking at comment (I hate
comments, but still, sometimes it's good to read them). I'm not sure which
'default' block should we keep. Why someone needed '*' in parser? Is it still
needed? If we stay with "unexpected_token" (I'd prefer that) I think that
comment should be killed too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
