[
https://issues.apache.org/jira/browse/THRIFT-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087559#comment-15087559
]
ASF GitHub Bot commented on THRIFT-3528:
----------------------------------------
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169691258
thrift_reserved_keyword(yytext); is used to report "Cannot use reserved
language keyword: " (reserved in Thrift target languages, not Thrift itself).
As "union" is already used by Thrift, it does not need to be additionally
reserved. "Public" is just repeated (looks like typo).
So for those changes: +1
But last one seems more complicated - at least looking at comment (I hate
comments, but still, sometimes it's good to read them). I'm not sure which
'default' block should we keep. Why someone needed '*' in parser? Is it still
needed? If we stay with "unexpected_token" (I'd prefer that) I think that
comment should be killed too.
> Fix warnings in thrift.ll
> -------------------------
>
> Key: THRIFT-3528
> URL: https://issues.apache.org/jira/browse/THRIFT-3528
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Trivial
>
> {code}
> /thrift/compiler/cpp/src/thriftl.ll:271: warning, rule cannot be matched
> /thrift/compiler/cpp/src/thriftl.ll:290: warning, rule cannot be matched
>
>
> /thrift/compiler/cpp/src/thriftl.ll:414: warning, rule cannot be matched
> {code}
> Seeing the code, the rules were redundant and no use at all as suggested by
> the warning messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
