[
https://issues.apache.org/jira/browse/THRIFT-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090651#comment-15090651
]
ASF GitHub Bot commented on THRIFT-3510:
----------------------------------------
Github user adam-resdiary commented on the pull request:
https://github.com/apache/thrift/pull/762#issuecomment-170244552
@Jens-G
> The project files are 2013 now. What minimum version of Mono is required?
I've actually just reverted the changed VS made to the solution file,
because I don't have access to my mono environment to test this right now. Is
that good enough for now? If not I'll figure something out.
> There are several files lacking the ASF license header. Could you add
that?
> Same for the new AssemblyInfo.cs file(s), the fields are incomplete.
That should be these problems sorted out now. I've just added fixup commits
for now so it was easy for you to see the changes in the PR. When you're happy
with them, I can rebase them so it makes more sense.
> Add HttpTaskAsyncHandler implementation
> ---------------------------------------
>
> Key: THRIFT-3510
> URL: https://issues.apache.org/jira/browse/THRIFT-3510
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Compiler, C# - Library
> Reporter: Adam Connelly
> Priority: Minor
>
> The THttpHandler doesn't support an async pipeline. This means that it's
> difficult for service implementations to make async calls. If there was an
> implementation of HttpTaskAsyncHandler, you could write services using async
> calls.
> Additionally, if you generate the C# classes with the current async support,
> you get a single interface with both sync and async methods. This doesn't
> really make sense on the server side since if you implement a service you end
> up leaving all the async method unimplemented. It would be useful if there
> were separate sync and async interfaces to make this a bit tidier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
