Github user adam-resdiary commented on the pull request:
https://github.com/apache/thrift/pull/762#issuecomment-170336556
@Jens-G @nsuke That's the changes added to get rid of the separateasync
flag and just use the async flag instead.
One thing I noticed is we've got #if preprocessor directives that only
include the Begin_, End_ methods if you're building for Silverlight. However,
these directives aren't included if you generate with ```async:true```, but
they do if you generate with ```asyncctp:true```. This means the Begin_, End_
methods are always included for async, but only included for asyncctp if you're
building for Silverlight.
I didn't want to change this behaviour since it's how the code currently
is, but it seems a bit inconsistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
