[
https://issues.apache.org/jira/browse/THRIFT-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091055#comment-15091055
]
ASF GitHub Bot commented on THRIFT-3510:
----------------------------------------
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/762#issuecomment-170352323
When editing the Thrift compiler C++ files please watch out and keep the
existing formatting. IIRC by default VS indents with tabs. We don't want tab
indents in that files (and we want LInux EOLs - git should take care about the
latter).
The async CTP stuff is only used with WP7 - which I removed from trunk just
a few minutes ago. It will not be used with WP8 or higher, as the only purpose
was to deal with some incompatible changes made between the async CTP and the
version that found its way into later frameworks.
With regard to this pull request and JIRA ticket I'd say we leave it as it
is for now. The flag is better removed either in a separate ticket or as
follow-up patch to the WP7 rermoval ticket.
> Add HttpTaskAsyncHandler implementation
> ---------------------------------------
>
> Key: THRIFT-3510
> URL: https://issues.apache.org/jira/browse/THRIFT-3510
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Compiler, C# - Library
> Reporter: Adam Connelly
> Priority: Minor
>
> The THttpHandler doesn't support an async pipeline. This means that it's
> difficult for service implementations to make async calls. If there was an
> implementation of HttpTaskAsyncHandler, you could write services using async
> calls.
> Additionally, if you generate the C# classes with the current async support,
> you get a single interface with both sync and async methods. This doesn't
> really make sense on the server side since if you implement a service you end
> up leaving all the async method unimplemented. It would be useful if there
> were separate sync and async interfaces to make this a bit tidier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
