[
https://issues.apache.org/jira/browse/THRIFT-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105788#comment-15105788
]
ASF GitHub Bot commented on THRIFT-3545:
----------------------------------------
Github user kdubb commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172646482
I am fairly sure that #797 fixes the line breaks and semi-colons in the
proper way. So, just check it with your code to make sure.
As far as performance of ARC I will just say that you attempt to be micro
optimizing code that is about to, or just has, sent data over a network
connection. Any thought to the nanosecond of time ARC *may* (and most likely
doesn't) add is not something we should be concerned about. Finally, this code
initializes static constants so discussing performance at all is unnecessary.
> Container type literals do not compile
> --------------------------------------
>
> Key: THRIFT-3545
> URL: https://issues.apache.org/jira/browse/THRIFT-3545
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Compiler
> Affects Versions: 1.0
> Reporter: Christopher Rogers
> Assignee: Christopher Rogers
> Fix For: 1.0
>
>
> Default values and constants of container type (array, dictionary, and set)
> do not compile. Semicolons are missing, and sets are missing an opening
> square bracket.
> I will provide a patch/pull request for this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)