[
https://issues.apache.org/jira/browse/THRIFT-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110314#comment-15110314
]
Simon South commented on THRIFT-3556:
-------------------------------------
This looks really good. Thank you, [~cjmay], for the work you're doing.
The only potential issue I see with this code is that it uses
{{[g_close|https://developer.gnome.org/glib/stable/glib-File-Utilities.html#g-close]}},
which wasn't available in GLib until version 2.36. This will break support for
(at least) CentOS 6, which is still on version 2.28. This may not be a strict
requirement but I'd suggest testing the GLib version with a preprocessor macro
and providing a separate implementation that uses {{close}} and handles error
reporting "manually".
My only other comment is that it would be nice if
{{thrift_fd_transport_set_property}} and {{thrift_fd_transport_get_property}}
issued a warning when passed an unrecognized property ID (as [the
example|https://developer.gnome.org/gobject/2.26/gobject-properties.html]
shows), though surprisingly this isn't done in the existing code either so it
isn't really an omission.
> c_glib file descriptor transport
> --------------------------------
>
> Key: THRIFT-3556
> URL: https://issues.apache.org/jira/browse/THRIFT-3556
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
> Affects Versions: 0.9.3
> Reporter: Chandler May
>
> c_glib library does not have any filesystem transports, including a file
> descriptor transport
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
