Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/817#discussion_r50622753
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -39,9 +39,11 @@
enum CLIENT_TYPE {
THRIFT_HEADER_CLIENT_TYPE = 0,
- THRIFT_FRAMED_DEPRECATED = 1,
- THRIFT_UNFRAMED_DEPRECATED = 2,
- THRIFT_UNKNOWN_CLIENT_TYPE = 4,
+ THRIFT_FRAMED_BINARY = 1,
+ THRIFT_UNFRAMED_BINARY = 2,
+ THRIFT_FRAMED_COMPACT = 3,
+ THRIFT_UNFRAMED_COMPACT = 4,
--- End diff --
(Moving the comment to right position as it was misleading)
@andrewcox @djwatson
Here I presume _DEPRECATED is only true for fbthrift.
Or is there any reason we should keep them and add the suffix to COMPACT ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
