Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/828#discussion_r51591170
--- Diff: lib/lua/src/luabpack.c ---
@@ -103,7 +104,7 @@ static int l_bunpack(lua_State *L) {
const char *code = luaL_checkstring(L, 1);
luaL_argcheck(L, code[1] == '\0', 0, "Format code must be one
character.");
const char *data = luaL_checkstring(L, 2);
- size_t len = lua_rawlen(L, 2);
+ size_t len = lua_objlen(L, 2);
--- End diff --
This breaks Lua 5.2+. We need for example #ifdef against Lua version macro.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
