[
https://issues.apache.org/jira/browse/THRIFT-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131973#comment-15131973
]
ASF GitHub Bot commented on THRIFT-3598:
----------------------------------------
GitHub user phongphan opened a pull request:
https://github.com/apache/thrift/pull/836
THRIFT-3598 Fixed Lua's TBufferedTransport
This should fixed Lua's binary-buffered client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phongphan/thrift THRIFT-3598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #836
----
commit 9275c6f40355e057e12c547b2898a5f7d001db2e
Author: Phongphan Phuttha <[email protected]>
Date: 2016-02-04T07:23:27Z
THRIFT-3598 Fixed TBufferedTransport constructor
commit 1622d8a40b49685692086ddb1367915187a901ec
Author: Phongphan Phuttha <[email protected]>
Date: 2016-02-04T07:26:28Z
THRIFT-3598 Enable Lua's binary buffered test client
commit fd91ee241fc09d7e61da83fe0f0cbdb4a96b8a10
Author: Phongphan Phuttha <[email protected]>
Date: 2016-02-04T08:36:48Z
THRIFT-3598 Use transport abstraction instead of socket
----
> TBufferedTransport doesn't instantiate client connection
> --------------------------------------------------------
>
> Key: THRIFT-3598
> URL: https://issues.apache.org/jira/browse/THRIFT-3598
> Project: Thrift
> Issue Type: Bug
> Components: Lua - Library
> Affects Versions: 0.9.3
> Environment: Linux
> Reporter: Phongphan Phuttha
>
> The TBufferedTransport doesn't seem to correctly instantiated.
> {code}
> local socket = TSocket:new{
> host = '127.0.0.1',
> port = 9090
> }
> assert(socket, 'Failed to create client socket')
> socket:setTimeout(5000)
> local transport = TBufferedTransport:new{
> trans = socket
> }
> assert(transport, 'Failed to create buffered transport')
> local protocol = TBinaryProtocol:new{
> trans = transport
> }
> assert(protocol, 'Failed to create binary protocol')
> local client = ThriftTestClient:new{
> protocol = protocol
> }
> assert(client, 'Failed to create client')
> -- Open the socket
> transport:open()
> client:ping()
> {code}
> The {{transport:open()}} doesn't open connection open to the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
