[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137329#comment-15137329
]
ASF GitHub Bot commented on THRIFT-3112:
----------------------------------------
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/500#issuecomment-181494987
@mreve I've added some explanation on
https://issues.apache.org/jira/browse/THRIFT-3112, but this patch should
in-fact be typed differently (today). FWICT the typing needed though is fairly
broken and your typing - which matches server side processor typing - should be
the way we move forward. I may move the discussion in
https://issues.apache.org/jira/browse/THRIFT-3112 to a PROPOSAL thread that
proposes fixing the client side typing which will be a breaking change for
users.
> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> ------------------------------------------------------------------
>
> Key: THRIFT-3112
> URL: https://issues.apache.org/jira/browse/THRIFT-3112
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler
> Affects Versions: 0.9.2
> Reporter: Sergei Egorov
> Assignee: John Sirois
> Labels: easyfix
>
> AsyncMethodCallback is generic, but current Java code generator is not adding
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback<String>
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
