[
https://issues.apache.org/jira/browse/THRIFT-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138411#comment-15138411
]
Hudson commented on THRIFT-3596:
--------------------------------
SUCCESS: Integrated in Thrift-precommit #45 (See
[https://builds.apache.org/job/Thrift-precommit/45/])
THRIFT-3596 Better conformance to PEP8 (nsuke:
[https://github.com/apache/thrift/commit/10308cb975ac090584068d0470b81e41555b2f35])
* contrib/zeromq/TZmqClient.py
* test/crossrunner/test.py
* contrib/parse_profiling.py
* test/py/TestFrozen.py
* lib/py/src/protocol/__init__.py
* lib/py/test/test_sslsocket.py
* lib/py/src/server/THttpServer.py
* contrib/fb303/py/setup.py
* test/features/util.py
* test/features/string_limit.py
* test/test.py
* lib/py/test/thrift_json.py
* contrib/zeromq/TZmqServer.py
* lib/py/src/transport/THttpClient.py
* test/py/SerializationTest.py
* lib/py/src/server/TServer.py
* lib/py/setup.py
* contrib/fb303/py/fb303/FacebookBase.py
* test/py.tornado/test_suite.py
* lib/py/src/Thrift.py
* test/crossrunner/collect.py
* test/crossrunner/run.py
* test/py/FastbinaryTest.py
* test/crossrunner/util.py
* lib/py/test/_import_local_thrift.py
* lib/py/src/protocol/TMultiplexedProtocol.py
* lib/py/src/server/TNonblockingServer.py
* test/py/TSimpleJSONProtocolTest.py
* contrib/async-test/test-leaf.py
* lib/py/src/transport/TSocket.py
* test/features/local_thrift/__init__.py
* test/py/TestEof.py
* lib/py/src/protocol/TCompactProtocol.py
* lib/py/src/compat.py
* test/py/RunClientServer.py
* lib/py/src/transport/TSSLSocket.py
* contrib/zeromq/test-server.py
* test/py/TestSocket.py
* test/features/container_limit.py
* test/crossrunner/report.py
* lib/py/src/transport/TTransport.py
* lib/py/src/protocol/TJSONProtocol.py
* test/py.twisted/test_suite.py
* lib/py/src/protocol/TBinaryProtocol.py
* lib/py/src/transport/TTwisted.py
* lib/py/src/TMultiplexedProcessor.py
* test/py/TestClient.py
* lib/py/src/TTornado.py
* contrib/zeromq/test-client.py
* lib/py/src/protocol/TProtocol.py
* lib/py/src/server/TProcessPoolServer.py
* test/features/theader_binary.py
* tutorial/php/runserver.py
* contrib/fb303/py/fb303_scripts/fb303_simple_mgmt.py
* test/crossrunner/compat.py
* lib/py/src/protocol/TBase.py
* lib/py/src/transport/TZlibTransport.py
* lib/py/src/TSCons.py
* test/py/TestServer.py
* lib/py/src/protocol/TProtocolDecorator.py
> Better conformance to PEP8
> --------------------------
>
> Key: THRIFT-3596
> URL: https://issues.apache.org/jira/browse/THRIFT-3596
> Project: Thrift
> Issue Type: Improvement
> Components: Python - Library
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Minor
> Labels: RFC
> Fix For: 0.9.4
>
>
> py coding_standards.md states it follows PEP8 but currently it does not do so
> at all.
> So a typical experience of a first-time (potential) py contributor would be
> to see red warnings all over the display and then has to either adjust their
> editor's settings or stop there.
> On the other hand, a huge downside of global reformat is git-blame experience
> but will be mostly mitigated by git blame -w in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
