GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/841
lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.
Previously, the server socket might not be fully closed from a prior
test, leading to flaky port bind failures in CI. Avoid the issue
altogether by binding an ephemeral port.
Add a TODO to TestPortFixture.h to warn folks away from its usage
and link THRIFT-3609 to track the work of removing or replacing it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3608
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #841
----
commit d26dc7a655456c26c604cae55c42ea2770254460
Author: John Sirois <[email protected]>
Date: 2016-02-10T17:14:51Z
Fixup SecurityTest to use ephemeral ports.
Previously, the server socket might not be fully closed from a prior
test, leading to flaky port bind failures in CI. Avoid the issue
altogether by binding an ephemeral port.
Add a TODO to TestPortFixture.h to warn folks away from its usage
and link THRIFT-3609 to track the work of removing or replacing it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
