[
https://issues.apache.org/jira/browse/THRIFT-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145780#comment-15145780
]
ASF GitHub Bot commented on THRIFT-3626:
----------------------------------------
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/857
THRIFT-3626 Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemera…
…l ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TServerSocket` listening on an ephemeral port would be DRYed
up into a helper of some sort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3626
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #857
----
commit aae84b40a7ff3a78b06b02efc4c2c744251914ea
Author: John Sirois <[email protected]>
Date: 2016-02-13T04:07:49Z
THRIFT-3626 Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral
ports.
Instead of using a fixed port, use an ephemeral port to improve
robustness and make way for parallelizability.
This change has an undesirable amount of repeated code but this fact is
not different from the prior so being a bit expedient here. Ideally
setup of a `TServerSocket` listening on an ephemeral port would be DRYed
up into a helper of some sort.
----
> Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.
> -----------------------------------------------------------------
>
> Key: THRIFT-3626
> URL: https://issues.apache.org/jira/browse/THRIFT-3626
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library, Test Suite
> Reporter: John Sirois
> Assignee: John Sirois
>
> As part of work on THRIFT-3609, eliminate use of TestPortFixture.h from
> TSocketInterruptTest.cpp.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
