[
https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145980#comment-15145980
]
ASF GitHub Bot commented on THRIFT-3623:
----------------------------------------
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/854#discussion_r52828211
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -91,8 +90,6 @@ BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL);
BOOST_GLOBAL_FIXTURE(GlobalFixtureSSL)
#endif
-BOOST_FIXTURE_TEST_SUITE(TSSLSocketInterruptTest, TestPortFixture)
--- End diff --
Can you keep 3 of these as BOOST_**AUTO**_TEST_SUITE ?
This would remove a namespace and put everything into global namespace.
In this regard, it seems that this one should have been placed before the
`keyDir` symbol already...
> Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports
> -----------------------------------------------------------------------
>
> Key: THRIFT-3623
> URL: https://issues.apache.org/jira/browse/THRIFT-3623
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Library, Test Suite
> Reporter: John Sirois
> Assignee: John Sirois
>
> As part of work on THRIFT-3609, eliminate use of TestPortFixture.h from
> TSSLSocketInterruptTest.cpp.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
