Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184295292
Actually test is failing quite badly.
Your fix is fine but the test needs fix too.
A possible fix is to replace the PI and golden ratio with float literals
and use the same digits in the assertions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
