[
https://issues.apache.org/jira/browse/THRIFT-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155933#comment-15155933
]
Richard Tsai commented on THRIFT-3619:
--------------------------------------
This workaround will break gtest on OSX with clang libc++.
Using C\+\+11 should have already implied {{GTEST_USE_OWN_TR1_TUPLE=0}}, but
manually setting this macro to {{0}} will just make gtest skip checking C\+\+11
and include {{tr1/tuple}} rather than {{tuple}}, which seems like a bug in
gtest, as I see it. See
[this|https://github.com/google/googletest/blob/77d6b173380332b1c1bc540532641f410ec82d65/googletest/include/gtest/internal/gtest-port.h#L640].
{{tr1/tuple}} works for libstdc++ even on C\+\+11, but not for libc++.
I think thrift should detect C\+\+11 and switch to the non-tr1-prefixed headers
when available, just like what gtest does, and not depend on the odd behavior
of {{GTEST_USE_OWN_TR1_TUPLE}}.
> Using Thrift 0.9.3 with googletest on Linux gcc 4.9 / C++11
> -----------------------------------------------------------
>
> Key: THRIFT-3619
> URL: https://issues.apache.org/jira/browse/THRIFT-3619
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Reporter: Wes McKinney
> Fix For: 0.10.0
>
>
> In PARQUET-470 we've been tracking some issues we've run into with Thrift
> 0.9.2 and 0.9.3. There is a conflict concerning {{std::tuple}} and so far
> have been unable to determine a workaround. Can you please advise and confirm
> whether this should be considered a bug in Thrift? Thank you
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
