[ 
https://issues.apache.org/jira/browse/THRIFT-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172158#comment-15172158
 ] 

ASF GitHub Bot commented on THRIFT-3599:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/914

    THRIFT-3599 Validate client IP address against cert's SubjectAltName

    follow-up: Fix required version of Python or dependency

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3599-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #914
    
----
commit 3fd0f675bc2847ae44f1b3d8bf4a2a4fb8ac3808
Author: Nobuaki Sukegawa <[email protected]>
Date:   2016-02-29T17:09:11Z

    THRIFT-3599 Validate client IP address against cert's SubjectAltName
    
    follow-up: Fix required version of Python or dependency

----


> Validate client IP address against cert's SubjectAltName
> --------------------------------------------------------
>
>                 Key: THRIFT-3599
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3599
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Critical
>             Fix For: 0.10.0
>
>
> After THRIFT-3505, python TSSLSocket has client cert support but does not 
> perform any hostname matching.
> That means clients can submit any certificate that is unrelated to them and 
> the server side only check if the cert is in their CA.
> It is in a sense worse than nothing as it can introduce false sense of 
> security.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to