[ 
https://issues.apache.org/jira/browse/THRIFT-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172225#comment-15172225
 ] 

Hudson commented on THRIFT-3699:
--------------------------------

SUCCESS: Integrated in Thrift-precommit #233 (See 
[https://builds.apache.org/job/Thrift-precommit/233/])
THRIFT-3699 Fix integer limit symbol includes in Python C extension (nsuke: 
[https://github.com/apache/thrift/commit/d7ff35a3f03485d8652acc0406f9346bef89851f])
* lib/py/src/ext/protocol.tcc
* lib/py/src/ext/module.cpp
* lib/py/src/ext/protocol.h
* lib/py/src/ext/types.h


> Fix integer limit symbol includes in Python C extension
> -------------------------------------------------------
>
>                 Key: THRIFT-3699
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3699
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Python - Library
>    Affects Versions: 0.10.0
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>             Fix For: 0.10.0
>
>
> INT32_MAX etc was not included correctly
> Newer GCC and Clang are permissive enough to accept them but it didn't work 
> on our CentOS 6 image.
> Rather than doing C-compatibility includes correctly, I replaced them with 
> std::numeric_limits.
> The patch also adds workaround for VC++ where std::numeric_limits does not 
> work in a single particular place of code for some reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to