[
https://issues.apache.org/jira/browse/THRIFT-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174422#comment-15174422
]
ASF GitHub Bot commented on THRIFT-3702:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/917
THRIFT-3702 Fix cross tests for Dart compact protocol (3 failing)
I looked at Go-Dart locally, and the response body from the Go server
appears to be empty. Go server - Java client also fails for me for http. So
without much more time to investigate, I think the best course of action is to
add these to known_failures_Linux.json to allow CI to pass. There are already
other combinations excluded for those server - transport pairs.
go-dart compact http-ip failure(13)
hs-dart compact framed-ip failure(13)
cpp-dart compact http-ip failure(13)
THRIFT-3702
@brianshannan-wf
@stevenosborne-wf
@tylertreat-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-3702
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/917.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #917
----
commit 57eede97d8b6a98f6e1d5479803bdebfeb0391b0
Author: Mark Erickson <[email protected]>
Date: 2016-03-01T21:14:40Z
I looked at Go-Dart locally, and the response body from the Go server
appears to be empty. Go server - Java client also fails for me for http. So
without much more time to investigate, I think the best course of action is to
add these to known_failures_Linux.json to allow CI to pass. There are already
other combinations excluded for those server - transport pairs.
go-dart compact http-ip failure(13)
hs-dart compact framed-ip failure(13)
cpp-dart compact http-ip failure(13)
THRIFT-3702
----
> Fix cross tests for Dart compact protocol (3 failing)
> -----------------------------------------------------
>
> Key: THRIFT-3702
> URL: https://issues.apache.org/jira/browse/THRIFT-3702
> Project: Thrift
> Issue Type: Bug
> Components: Dart - Library
> Reporter: Mark Erickson
> Assignee: Mark Erickson
>
> These tests are failing - interesting that it's just these combinations.
> Other combinations of dart + compact are passing for the same languages and
> transports.
> https://travis-ci.org/apache/thrift/builds/112681653
> {code}
> ==========================================================================
> *** Following 3 failures were unexpected ***:
> If it is introduced by you, please fix it before submitting the code.
> ==========================================================================
> server-client: protocol: transport: result:
> go-dart compact http-ip failure(13)
> hs-dart compact framed-ip failure(13)
> cpp-dart compact http-ip failure(13)
> ==========================================================================
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
