[
https://issues.apache.org/jira/browse/THRIFT-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182228#comment-15182228
]
Chandler May commented on THRIFT-3569:
--------------------------------------
It's troubling that you didn't reproduce the error using those tests, though.
I think r_buf_size in thrift_framed_transport doesn't do what I thought. Also,
the implementation of read in thrift_socket loops until the requested number of
bytes is read.
Looking more closely, neither r_buf_size nor w_buf_size have any effect in
thrift_framed_transport; also, read_all should be used in read_frame... in any
case, the best way to fix the tests for the current issue might be just to
create a fake transport.
> c_glib protocols do not check number of bytes read by transport
> ---------------------------------------------------------------
>
> Key: THRIFT-3569
> URL: https://issues.apache.org/jira/browse/THRIFT-3569
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Library
> Affects Versions: 0.9.3
> Reporter: Chandler May
> Assignee: Chandler May
> Fix For: 0.10.0
>
>
> I propose adding a read_all method to the thrift_transport interface with the
> obvious default implementation and using that. This would facilitate
> implementation of other protocols.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
