[
https://issues.apache.org/jira/browse/THRIFT-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191516#comment-15191516
]
ASF GitHub Bot commented on THRIFT-3735:
----------------------------------------
GitHub user tylertreat-wf opened a pull request:
https://github.com/apache/thrift/pull/943
THRIFT-3735 JSON protocol left in incorrect state when an exception is
thrown during read or write operations
The JSON context stack may be left in an incorrect state when an
exception is thrown during read or write operations. This leads to
further errors while writing/reading the NEXT message, because incorrect
characters may be written or expected.
This is related to THRIFT-1473, but there is an additional issue in that
the bufio.Writer needs to be reset if an error occurs.
@markerickson-wf
@stevenosborne-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tylertreat-wf/thrift THRIFT-3735
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #943
----
commit f1740ed8faf767a486d2ab38be2401dcb2288cee
Author: Tyler Treat <[email protected]>
Date: 2016-03-11T21:15:17Z
THRIFT-3735 JSON protocol left in incorrect state when an exception is
thrown during read or write operations
The JSON context stack may be left in an incorrect state when an
exception is thrown during read or write operations. This leads to
further errors while writing/reading the NEXT message, because incorrect
characters may be written or expected.
This is related to THRIFT-1473, but there is an additional issue in that
the bufio.Writer needs to be reset if an error occurs.
----
> JSON protocol left in incorrect state when an exception is thrown during read
> or write operations
> -------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3735
> URL: https://issues.apache.org/jira/browse/THRIFT-3735
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Tyler Treat
>
> The JSON context stack may be left in an incorrect state when an exception is
> thrown during read or write operations. This leads to further errors while
> writing/reading the NEXT message, because incorrect characters may be written
> or expected.
> This is related to THRIFT-1473, but there is an additional issue in that the
> bufio.Writer needs to be reset if an error occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
