[
https://issues.apache.org/jira/browse/THRIFT-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192002#comment-15192002
]
ASF GitHub Bot commented on THRIFT-3734:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/942#issuecomment-195832010
@mygityf it's a haskell dependency build failure but doesn't seem to be
reproducible. It's obviously not related to your patch.
And thanks for fixing the other side of the cross lang again. D http
implementation is indeed weak and patches are much appreciated.
> To compare two string as lowercase.
> -----------------------------------
>
> Key: THRIFT-3734
> URL: https://issues.apache.org/jira/browse/THRIFT-3734
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
> Affects Versions: 0.9.3
> Reporter: WangYaofu
> Assignee: WangYaofu
> Fix For: 0.9.3
>
>
> static bool compToLower(ubyte a, ubyte b) {
> return a == toLower(cast(char)b);
> }
> it looks unexpected result got when parameter a is uppercase and b is
> lowercase.
> if (startsWith!compToLower(split[0], cast(ubyte[])"content-length")) {
> ...
> }
> split[0] is string of 'Content-Length', it contains character with uppercase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
