Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/821#discussion_r55930217
--- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.c ---
@@ -209,16 +242,39 @@ thrift_memory_buffer_class_init
(ThriftMemoryBufferClass *cls)
param_spec = g_param_spec_uint ("buf_size",
"buffer size (construct)",
- "Set the read buffer size",
+ "Set the read/write buffer size limit"
+ " (0 for unlimited)",
0, /* min */
--- End diff --
` " (0 for unlimited)", 0, /* min */` is confusing. Is the minimum
actually unlimited ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---