[
https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cherrot Luo updated THRIFT-3737:
--------------------------------
Description:
h2. Description
Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true, even
if the underlying TCP connection has been closed or reset by the peer, unless
you manually invoke its close() method.
This is because the isOpen method takes a simple but kind of "irresponsible"
way to judge connection status:
{code:title=TSocket.py}
def isOpen(self):
return self.handle is not None
{code}
This may affect the upstream lib/tools' implementation to offer a *reliable*
transport instance.
For example, in [happybase|https://github.com/wbolster/happybase] (a
developer-friendly Python library to interact with Apache HBase), it use
isOpen() to judge whether it neccessary to reopen the connection in its
[connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
and connection pool.
h2. Fix
I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]
The implementation is according to Python's
*[urllib3|https://github.com/shazow/urllib3/blob/0f98217c8125848dd3eded84d11b83c5caefaa97/urllib3/util/connection.py#L13]*
module -- The most widely used Python HTTP library.
was:
h2. Description
Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true, even
if the underlying TCP connection has been closed or reset by the peer, unless
you manually invoke its close() method.
This is because the isOpen method takes a simple but kind of "irresponsible"
way to judge connection status:
{code:title=TSocket.py}
def isOpen(self):
return self.handle is not None
{code}
This may affect the upstream lib/tools' implementation to offer a *reliable*
transport instance.
For example, in [happybase|https://github.com/wbolster/happybase] (a
developer-friendly Python library to interact with Apache HBase), it use
isOpen() to judge whether it neccessary to reopen the connection in its
[connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
and connection pool.
h2. Fix
I would send a pull request to the github repo later.
The implementation is according to Python's
*[urllib3|https://github.com/shazow/urllib3/blob/0f98217c8125848dd3eded84d11b83c5caefaa97/urllib3/util/connection.py#L13]*
module -- The most widely used Python HTTP library.
> Improve TSocket isOpen() implementation to give more accurate connection
> status.
> --------------------------------------------------------------------------------
>
> Key: THRIFT-3737
> URL: https://issues.apache.org/jira/browse/THRIFT-3737
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Reporter: Cherrot Luo
> Labels: patch
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> h2. Description
> Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true,
> even if the underlying TCP connection has been closed or reset by the peer,
> unless you manually invoke its close() method.
> This is because the isOpen method takes a simple but kind of "irresponsible"
> way to judge connection status:
> {code:title=TSocket.py}
> def isOpen(self):
> return self.handle is not None
> {code}
> This may affect the upstream lib/tools' implementation to offer a *reliable*
> transport instance.
> For example, in [happybase|https://github.com/wbolster/happybase] (a
> developer-friendly Python library to interact with Apache HBase), it use
> isOpen() to judge whether it neccessary to reopen the connection in its
> [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
> and connection pool.
> h2. Fix
> I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]
> The implementation is according to Python's
> *[urllib3|https://github.com/shazow/urllib3/blob/0f98217c8125848dd3eded84d11b83c5caefaa97/urllib3/util/connection.py#L13]*
> module -- The most widely used Python HTTP library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
