[ 
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202839#comment-15202839
 ] 

Hudson commented on THRIFT-3112:
--------------------------------

SUCCESS: Integrated in Thrift-precommit #335 (See 
[https://builds.apache.org/job/Thrift-precommit/335/])
THRIFT-3112 [Java] AsyncMethodCallback should be typed in generated (nsuke: 
[https://github.com/apache/thrift/commit/bd964c7f3460c308161cb6eb90583874a7d8d848])
* lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java
* lib/java/test/org/apache/thrift/server/ServerTestBase.java
* test/DebugProtoTest.thrift
* lib/java/test/org/apache/thrift/protocol/ProtocolTestBase.java
* compiler/cpp/src/generate/t_java_generator.cc
* lib/java/test/org/apache/thrift/async/TestTAsyncClientManager.java
* lib/java/src/org/apache/thrift/async/AsyncMethodCallback.java
Follow-up THRIFT-3112: key.cancel when error (nsuke: 
[https://github.com/apache/thrift/commit/c3072227c06c570135741b625db612aaccff67b3])
* lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java


> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3112
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3112
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler, Java - Library
>    Affects Versions: 0.9.2, 0.9.3
>            Reporter: Sergei Egorov
>            Assignee: John Sirois
>             Fix For: 0.10.0
>
>
> AsyncMethodCallback is generic, but current Java code generator is not adding 
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback<String> 
> resultHandler) throws org.apache.thrift.TException;
>  }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
>     public void ping(org.apache.thrift.async.AsyncMethodCallback 
> resultHandler) throws org.apache.thrift.TException;
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to