[
https://issues.apache.org/jira/browse/THRIFT-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201580#comment-15201580
]
ASF GitHub Bot commented on THRIFT-3449:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/954
THRIFT-3449 TBaseAsyncProcessor fb.responseReady() never called for o…
…neway functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #954
----
commit 400ae6e76e07ec929125c1d78b11541eeb254de2
Author: Nobuaki Sukegawa <[email protected]>
Date: 2016-03-18T13:27:38Z
THRIFT-3449 TBaseAsyncProcessor fb.responseReady() never called for oneway
functions
----
> TBaseAsyncProcessor fb.responseReady() never called for oneway functions
> ------------------------------------------------------------------------
>
> Key: THRIFT-3449
> URL: https://issues.apache.org/jira/browse/THRIFT-3449
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.3
> Environment: java libthrift-0.9.3
> Reporter: Jan Sileny
> Labels: newbie, patch
> Fix For: 0.10.0
>
> Attachments: responseReadyPatch.patch
>
>
> For regular service functions, fb.responseReady() is called from generated
> AsyncProcessFunction's sendResponse(...). Precisely in its result handler's
> AsyncMethodCallback onComplete or onError implementations. Because oneway
> methods have void result handler's onComplete and onError implementations,
> responseReady is not called and frame buffer never goes back to reading
> state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
