[
https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203091#comment-15203091
]
ASF GitHub Bot commented on THRIFT-3750:
----------------------------------------
GitHub user zachhowe opened a pull request:
https://github.com/apache/thrift/pull/958
THRIFT-3750 Check isSet in copyWithZone
For each property being copied to the new object, ensure isSet is checked
before setting the new object's property. Otherwise isSet will always be YES on
new object even if it was not set to YES on the original object. This ensures
the new copied object is a true copy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zachhowe/thrift THRIFT-3750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #958
----
commit 39894afdd79fc54652e57afb4e42c6c871a9ea77
Author: Zach Howe <[email protected]>
Date: 2016-03-20T04:13:31Z
THRIFT-3750 Check isSet in copyWithZone
For each property being copied to the new object, ensure isSet is checked
before setting the new object's property. Otherwise isSet will always be YES on
new object even if it was not set to YES on the original object. This ensures
the new copied object is a true copy.
----
> NSCopying copyWithZone: implementation does not check isSet
> -----------------------------------------------------------
>
> Key: THRIFT-3750
> URL: https://issues.apache.org/jira/browse/THRIFT-3750
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Compiler
> Reporter: Zach Howe
> Priority: Critical
>
> The NSCopying copyWithZone: implementation does not check isSet. This causes
> the copy not to be a true copy, since all the isSet properties will be set to
> YES on the newly copied object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
