[
https://issues.apache.org/jira/browse/THRIFT-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209310#comment-15209310
]
ASF GitHub Bot commented on THRIFT-3755:
----------------------------------------
GitHub user tpcwang opened a pull request:
https://github.com/apache/thrift/pull/960
THRIFT-3755 TDebugProtocol::writeString hits assert in isprint on Windows
with debug CRT
Passing characters <0 to std::isprint causes asserts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tpcwang/thrift THRIFT-3755
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/960.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #960
----
commit 711156629f3ddca81f7c33c0307e1eaf32f27f84
Author: tpcwang <[email protected]>
Date: 2016-03-23T22:22:33Z
Fix TDebugProtocol::writeString to avoid assertion in isprint
----
> TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT
> ----------------------------------------------------------------------------
>
> Key: THRIFT-3755
> URL: https://issues.apache.org/jira/browse/THRIFT-3755
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: Ted Wang
> Priority: Minor
>
> Passing characters <0 to std::isprint causes asserts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
