[
https://issues.apache.org/jira/browse/THRIFT-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211688#comment-15211688
]
ASF GitHub Bot commented on THRIFT-3764:
----------------------------------------
GitHub user goldie80 opened a pull request:
https://github.com/apache/thrift/pull/969
THRIFT-3764: Ensure PHP TSimpleJSONProtocol and TMultiplexedProtocol files
included during "make install"
If using "make install" to install the PHP client libraries, these files
are currently not included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/goldie80/thrift THRIFT-3764
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #969
----
commit f9d76750c9aaa92d3e61f86ca2f20a6f05742c79
Author: Mark Goldfinch <[email protected]>
Date: 2016-03-25T10:28:43Z
Ensure PHP TSimpleJSONProtocol and TMultiplexedProtocol files included
during "make install"
----
> PHP "make install" does not install TMultiplexedProtocol.php nor
> TSimpleJSONProtocol.php
> ----------------------------------------------------------------------------------------
>
> Key: THRIFT-3764
> URL: https://issues.apache.org/jira/browse/THRIFT-3764
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Reporter: Mark Goldfinch
> Priority: Minor
> Labels: php
>
> lib/php/Makefile.am does not include:
> {code}
> lib/Thrift/TMultiplexedProcessor.php
> lib/Thrift/Protocol/TMultiplexedProtocol.php
> lib/Thrift/Protocol/TProtocol.php
> lib/Thrift/Protocol/TProtocolDecorator.php
> lib/Thrift/Protocol/TSimpleJSONProtocol.php
> lib/Thrift/Protocol/SimpleJSON/CollectionMapKeyException.php
> lib/Thrift/Protocol/SimpleJSON/Context.php
> lib/Thrift/Protocol/SimpleJSON/ListContext.php
> lib/Thrift/Protocol/SimpleJSON/MapContext.php
> lib/Thrift/Protocol/SimpleJSON/StructContext.php
> {code}
> which are all support files for either TMultiplexedProtocol.php or
> TSimpleJSON.php.
> If using "make install" to install the PHP client library, these files are
> excluded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
