[
https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223231#comment-15223231
]
ASF GitHub Bot commented on THRIFT-3737:
----------------------------------------
Github user cherrot commented on the pull request:
https://github.com/apache/thrift/pull/945#issuecomment-204951251
Yes you are right, using `isActive` would invoke `select/poll` and `recv`
system calls than a straight forward `send`.
As a lower layer library, I think it would be nice to provide a convenient
API telling the underlying state. Users could decide whether to use this or not.
And what is the [`peek` method in C++
lib](https://github.com/apache/thrift/blob/cdc83335d60756c4bfb0d2c8af7933500c9e3c06/lib/cpp/src/thrift/transport/TSocket.cpp#L181-L235)
for? Is there anything wrong with it?
> Improve TSocket isOpen() implementation to give more accurate connection
> status.
> --------------------------------------------------------------------------------
>
> Key: THRIFT-3737
> URL: https://issues.apache.org/jira/browse/THRIFT-3737
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Reporter: Cherrot Luo
> Labels: patch
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> h2. Description
> Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true,
> even if the underlying TCP connection has been closed or reset by the peer,
> unless you manually invoke its close() method.
> This is because the isOpen method takes a simple but kind of "irresponsible"
> way to judge connection status:
> {code:title=TSocket.py}
> def isOpen(self):
> return self.handle is not None
> {code}
> This may affect the downstream lib/tools' implementation to offer a
> *reliable* transport instance.
> For example, in [happybase|https://github.com/wbolster/happybase] (a
> developer-friendly Python library to interact with Apache HBase), it use
> isOpen() to judge whether it neccessary to reopen the connection in its
> [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
> and connection pool.
> h2. Fix
> I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
