[ 
https://issues.apache.org/jira/browse/THRIFT-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223805#comment-15223805
 ] 

ASF GitHub Bot commented on THRIFT-3770:
----------------------------------------

Github user vmarkovtsev commented on the pull request:

    https://github.com/apache/thrift/pull/972#issuecomment-205184422
  
    @nsuke, about the generic wrapper, I feel bad about these dupes too but 
cannot see the possibility because asyncio coroutine's "viral" nature with 
"yield from" is going to infect every piece of reading code. What's even worse, 
"yield from" result in SyntaxError on Python 2.7. In order to support all the 
protocols, we will have to adapt each existing Protocol similar to what's done 
to Binary. Framed's already been ported, so I don't think it is too hard anyway.
    
    gen_asyncio_ - overseen, fixed.
    
    I will add the tests in a separate commit in this PR, thanks.


> Support Python 3.4+ asyncio support
> -----------------------------------
>
>                 Key: THRIFT-3770
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3770
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler, Python - Library
>    Affects Versions: 1.0
>            Reporter: Vadim Markovtsev
>            Priority: Minor
>              Labels: features
>
> Currently, Tornado and Twisted async engines are supported in client lib and 
> the compiler. asyncio is a relatively new engine which is included into 
> Python 3.4+ standard library. It is gaining popularity fast.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to