[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224760#comment-15224760
]
James E. King, III edited comment on THRIFT-3768 at 4/4/16 8:32 PM:
--------------------------------------------------------------------
[~ben.craig] Ideally we would remove TThreadedServer and have implementations
transition to TThreadPoolServer which provides the same functionality. Given
how fundamentally broken the TThreadedServer is provided in thrift-0.9.3 and
the lack of feedback on the subject, I'm implementing TThreadedServer as a
subclass of TThreadPoolServer.
was (Author: jking3):
[~ben.craig] Ideally we would remove TThreadedServer and have implementations
transition to TThreadPoolServer which provides the same functionality. Given
how fundamentally broken the TThreadedServer is provided in thrift-0.9.3 and
the lack of feedback on the subject, I'm removing it as part of this work which
relates to THRIFT-3096.
There's no good reason to maintain both threaded server implementations other
than backwards compatibility, which is easily fixed with a minor code change by
the consumer.
> TThreadedServer may crash if it is destroyed immediately after it returns
> from serve()
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-3768
> URL: https://issues.apache.org/jira/browse/THRIFT-3768
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: Ted Wang
> Assignee: James E. King, III
> Priority: Minor
>
> Here's a sequence that shows the race:
> Thread-1 (Users of TThreadedServer): Calls TThreadedServer::stop(), which
> calls interruptChildren and initiates the tearing down of client connections.
> Thread-2: In TServerFramework::serve(), broke out of accept, and now blocks
> in TThreadedServer::serve() waiting to drain all the clients.
> Thread-3 (The connected client thread created by TThreadedServer): In
> disposeConnectedClient, running because the server is shutting down and the
> shared_ptr specified this function to be the cleanup function for the client.
> This thread just returned from onClientDisconnected and now context switches.
> Thread-2: TThreadedServer::serve() is notified that all of the clients have
> disconnected and completes.
> Thread-1: Joins on Thread-2 and destroys the server object because it is done.
> Thread-3: Finally gets a chance to run, but now encounters undefined behavior
> because it is still executing a member function of an object that has been
> destroyed.
> You can force this race in action if you put sleep(1) before
> onClientDisconnected() in disposeConnectedClient
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
