GitHub user stevenosborne-wf opened a pull request:

    https://github.com/apache/thrift/pull/983

    THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64

    Reading/writing `i64` is broken using the binary protocol when compiled to 
js. Use the [`fixnum`](https://pub.dartlang.org/packages/fixnum) library to 
address this. Note: fixnum `Int64` is already used in the [compact 
protocol](https://github.com/apache/thrift/blob/master/lib/dart/lib/src/protocol/t_compact_protocol.dart#L246)
 to correct the same issue.
    
    @markerickson-wf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevenosborne-wf/thrift thrift_3780

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #983
    
----
commit acb4a4b891655544c434afad2f3491e16f2bd1ca
Author: Steven Osborne <[email protected]>
Date:   2016-04-07T15:20:59Z

    THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to