[
https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230514#comment-15230514
]
ASF GitHub Bot commented on THRIFT-3784:
----------------------------------------
Github user csosborn commented on a diff in the pull request:
https://github.com/apache/thrift/pull/984#discussion_r58903035
--- Diff:
contrib/thrift-maven-plugin/src/main/java/org/apache/thrift/maven/AbstractThriftMojo.java
---
@@ -319,15 +331,6 @@ public boolean accept(File dir, String name) {
return ImmutableSet.copyOf(thriftFilesInDirectory);
}
- ImmutableSet<File> findThriftFilesInDirectories(Iterable<File>
directories) throws IOException {
- checkNotNull(directories);
- Set<File> thriftFiles = newHashSet();
- for (File directory : directories) {
- thriftFiles.addAll(findThriftFilesInDirectory(directory));
- }
- return ImmutableSet.copyOf(thriftFiles);
- }
--- End diff --
This code was unused.
> thrift-maven-plugin generates invalid include directories for IDL in
> dependency JARs
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-3784
> URL: https://issues.apache.org/jira/browse/THRIFT-3784
> Project: Thrift
> Issue Type: Bug
> Reporter: Chris Osborn
>
> The thrift-maven-plugin attempts to support building .thrift files that
> depend on other .thrift files provided in a dependency JAR. It does this by
> copying the dependency JAR's thrift files into a temporary directory then
> passing corresponding include directory options to the thrift compiler.
> However, the process of generating the include directory paths is faulty:
> there is a path for each and every directory that contains a .thrift file,
> rather than a single path to the root of the thrift file hierarchy. That
> means that any thrift files that reference others using paths relative to a
> root will fail. It may happen to work where the thrift files are all in a
> single directory, but not in the general case.
> There are no tests of this support, so I've added a few in the pull request
> I'm preparing.
> Somebody found the exact same problem and issued a pull request against this
> plugin's original repository on Github:
> https://github.com/dtrott/maven-thrift-plugin/pull/28. It went nowhere
> because the project was already pending ASF acceptance at that point, but
> it's worth looking at as an additional reference.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
