[
https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240936#comment-15240936
]
Hudson commented on THRIFT-3467:
--------------------------------
FAILURE: Integrated in Thrift-precommit #408 (See
[https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3467 Go Maps for Thrift Sets Should Have Values of Type struct{} (jensg:
[https://github.com/apache/thrift/commit/ca714c4397ed78bd880f0dd76526e3817ecc08f0])
* test/go/src/bin/stress/main.go
* lib/go/thrift/serializer_types_test.go
* lib/go/test/tests/client_error_test.go
* test/go/src/common/mock_handler.go
* test/go/src/common/printing_handler.go
* test/go/src/common/simple_handler.go
* compiler/cpp/src/generate/t_go_generator.cc
* lib/go/test/tests/thrifttest_handler.go
* lib/go/test/tests/thrifttest_driver.go
* test/go/src/common/clientserver_test.go
* lib/go/thrift/serializer_test.go
* test/go/src/bin/testclient/main.go
> Go Maps for Thrift Sets Should Have Values of Type struct{}
> ------------------------------------------------------------
>
> Key: THRIFT-3467
> URL: https://issues.apache.org/jira/browse/THRIFT-3467
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.3
> Reporter: Tom Deering
> Assignee: artem antonenko
> Labels: golang
> Fix For: 0.11.0
>
>
> Sets in Thrift are currently turned into maps with boolean values in Go.
> Example:
> Thrift
> {code}
> namespace go bug
> service FooService{
> void bar (1:set<string> foos)
> }
> {code}
> Go
> {code}
> func (p *FooServiceClient) Bar(foos map[string]bool) (err error)
> {code}
> Boolean map values waste memory. Map values should be of the zero-byte
> struct{} type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
